Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hidden directories by default within the glob pattern #445

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ryanluker
Copy link
Owner

@ryanluker ryanluker commented Jul 13, 2024

Description

Based on a suggestion here #228 (comment) around ignoring hidden directories / folders by default.

Work

  • Ignore hidden folders by default (.venv, .git, etc)
  • Add test to confirm default glob ignores folders properly.

@ryanluker
Copy link
Owner Author

Tried the easiest option d66d8d7 but I think we need to go the more advance route of writing custom ignore functions (similar to what I posted here #228 (comment)). Definitely requires new test coverage though and not just a one line change sadly 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant