Merge pull request #453 from ryohey/fix-select-all-notes

fix ctrl+a to select all notes
ryohey · Feb 1, 2025 · 0cedc1c · 0cedc1c
2 parents adfe296 + d9ae967
commit 0cedc1c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/app/src/actions/selection.ts b/app/src/actions/selection.ts
@@ -318,12 +318,14 @@ export const useSelectAllNotes = () => {
   const {
     pianoRollStore,
     pianoRollStore: { selectedTrack },
+    controlStore,
   } = useStores()
   return () => {
     if (selectedTrack) {
       pianoRollStore.selectedNoteIds = selectedTrack.events
         .filter(isNoteEvent)
         .map((note) => note.id)
+      controlStore.selectedEventIds = []
     }
   }
 }
diff --git a/app/src/components/KeyboardShortcut/PianoRollKeyboardShortcut.tsx b/app/src/components/KeyboardShortcut/PianoRollKeyboardShortcut.tsx
@@ -1,6 +1,6 @@
 import { observer } from "mobx-react-lite"
 import { FC } from "react"
-import { usePasteSelection } from "../../actions"
+import { usePasteSelection, useSelectAllNotes } from "../../actions"
 import { usePasteControlSelection } from "../../actions/control"
 import {
   isControlEventsClipboardData,
@@ -23,6 +23,7 @@ export const PianoRollKeyboardShortcut: FC = observer(() => {
     useControlPaneKeyboardShortcutActions()
   const pasteSelection = usePasteSelection()
   const pasteControlSelection = usePasteControlSelection()
+  const selectAllNotes = useSelectAllNotes()
 
   // Handle pasting here to allow pasting even when the element does not have focus, such as after clicking the ruler
   const onPaste = (e: ClipboardEvent) => {
@@ -82,6 +83,11 @@ export const PianoRollKeyboardShortcut: FC = observer(() => {
           code: "Digit2",
           run: () => (pianoRollStore.mouseMode = "selection"),
         },
+        {
+          code: "KeyA",
+          metaKey: true,
+          run: selectAllNotes,
+        },
       ]}
       onPaste={onPaste}
     />

diff --git a/app/src/components/KeyboardShortcut/pianoNotesKeyboardShortcutActions.tsx b/app/src/components/KeyboardShortcut/pianoNotesKeyboardShortcutActions.tsx
@@ -4,7 +4,6 @@ import {
   useDuplicateSelection,
   usePasteSelection,
   useQuantizeSelectedNotes,
-  useSelectAllNotes,
   useSelectNextNote,
   useSelectPreviousNote,
   useTransposeSelection,
@@ -18,7 +17,6 @@ export const usePianoNotesKeyboardShortcutActions = () => {
   const deleteSelection = useDeleteSelection()
   const pasteSelection = usePasteSelection()
   const duplicateSelection = useDuplicateSelection()
-  const selectAllNotes = useSelectAllNotes()
   const quantizeSelectedNotes = useQuantizeSelectedNotes()
   const transposeSelection = useTransposeSelection()
   const { pianoRollStore } = useStores()
@@ -47,11 +45,6 @@ export const usePianoNotesKeyboardShortcutActions = () => {
       metaKey: true,
       run: duplicateSelection,
     },
-    {
-      code: "KeyA",
-      metaKey: true,
-      run: selectAllNotes,
-    },
     {
       code: "KeyQ",
       run: quantizeSelectedNotes,