fix(houses): change calc base into utc to calc base into calendar day #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this implementation was using the recommended methods for dates based on Coordinated Universal Time (UTC). These functions are recommended more for hours obtained from clock. The problem with them is that for some calculations they deliver differences with other libraries that use swesseph. Due to standardization issues with other libraries and to avoid confusion, it was decided to replace the implementation to be able to use the dates based on the calendar day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this implementation was using the recommended methods for
dates based on Coordinated Universal Time (UTC) UTC and Julian day: swe_utc_time_zone(), swe_utc_to_jd(), swe_jdet_to_utc(), swe_jdut1_to_utc().
These functions are recommended more for hours obtained from clock. The problem with them is that for some calculations they deliver differences with other libraries that use swesseph. Due to standardization issues with other libraries and to avoid confusion, it was decided to replace the implementation to be able to use the dates based on the calendar day.
Also, the functions for calculating the position of the planets are also changed in order to use the functions with Ephemeris time (ET) and leave a little more coherence in the calculations and be closer to what other softwares deliver.
For more info see #15
Resolve #15