Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File detection update #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

File detection update #107

wants to merge 1 commit into from

Conversation

mgenereu
Copy link

@mgenereu mgenereu commented Oct 4, 2022

File type detection is different under newer versions of Java and this adds support for null detection and alternate MIME strings.

File type detection is different under newer versions of Java 
and this adds support for null detection and alternate MIME 
strings.
@ghB111
Copy link

ghB111 commented Nov 9, 2022

May I suggest also explicitly checking magic bytes of file to guess if it's gzipped? FileTypeDetector docs say it may only check file extension, which can be misleading when, for example, you create a temp file in your pipeline and that information is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants