Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/refactor tests #25

Merged
merged 19 commits into from
Mar 5, 2024
Merged

Feat/refactor tests #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0f1da88
feat(test): add simplelogger config to remove noise when running test…
cmhulbert Feb 22, 2024
d12b257
fix: `KeyValueAccess#components(String)` should return input if only …
cmhulbert Feb 22, 2024
6a28479
refactor(test): combine test classes to parameterized test, with a ma…
cmhulbert Feb 22, 2024
493bd2e
feat: extract s3 specific static methods from N5Factory
cmhulbert Feb 23, 2024
7cf3440
refactor(test): separate backend and mock test classes
cmhulbert Feb 23, 2024
78f0a0e
feat(test): reuse bucket per test suit
cmhulbert Feb 23, 2024
cca9f86
fix: AWS KVA needs to keep track of the path from the bucket root to …
cmhulbert Feb 28, 2024
44f1045
feat(test): reuse buckets, remove temp buckets eagerly
cmhulbert Feb 28, 2024
7ef137f
test: replace MockUriTest with AmazonS3UtilsTest
bogovicj Feb 29, 2024
85b1424
style: formatting
cmhulbert Mar 1, 2024
8704c79
feat: use authority to keep port number if present
cmhulbert Mar 1, 2024
eb30815
feat: deprecate old reader
cmhulbert Mar 1, 2024
8379ec8
refactor: clean up redundant code
cmhulbert Mar 1, 2024
933905e
fix(test): occassionally there are erroneous NoSuchBucket errors when…
cmhulbert Mar 1, 2024
87341f1
chore: comment change
cmhulbert Mar 1, 2024
5d4728e
fix(test): this test works in IntelliJ and Eclipse, but not when run …
cmhulbert Mar 1, 2024
5d24c58
chore: bump n5 version
cmhulbert Mar 4, 2024
af4bcc0
fix: split Path into parts, since separators are platform specific
cmhulbert Mar 5, 2024
e9e84e6
style: remove whitespace
cmhulbert Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 33 additions & 19 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<groupId>org.janelia.saalfeldlab</groupId>
<artifactId>n5-aws-s3</artifactId>
<version>4.0.3-SNAPSHOT</version>
<version>4.1.0-SNAPSHOT</version>

<name>N5 AWS S3</name>
<description>N5 library implementation using Amazon Web Services S3 backend.</description>
Expand Down Expand Up @@ -120,7 +120,7 @@

<s3mock_2.12.version>0.2.5</s3mock_2.12.version>
<jaxb-api.version>2.2.2</jaxb-api.version>
<n5.version>3.1.3</n5.version>
<n5.version>3.2.0</n5.version>
</properties>

<dependencies>
Expand All @@ -132,6 +132,11 @@
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk-s3</artifactId>
</dependency>
<dependency>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
<version>3.0.2</version>
</dependency>

<!-- Test dependencies -->
<dependency>
Expand Down Expand Up @@ -172,23 +177,18 @@
</repositories>

<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludes>
<exclude>org.janelia.saalfeldlab.n5.s3.backend.N5AmazonS3BucketRootBackendTest</exclude>
<exclude>org.janelia.saalfeldlab.n5.s3.backend.N5AmazonS3ContainerPathBackendTest</exclude>
<exclude>org.janelia.saalfeldlab.n5.s3.backend.CachedN5AmazonS3BucketRootBackendTest</exclude>
<exclude>org.janelia.saalfeldlab.n5.s3.backend.CachedN5AmazonS3ContainerPathBackendTest</exclude>
<exclude>org.janelia.saalfeldlab.n5.s3.backend.BackendUriTest</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludes>
<exclude>org.janelia.saalfeldlab.n5.s3.backend.*.java</exclude>
<exclude>org.janelia.saalfeldlab.n5.s3.N5AmazonS3Tests.java</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</build>

<profiles>
Expand All @@ -201,5 +201,19 @@
<maven.compiler.release>${scijava.jvm.version}</maven.compiler.release>
</properties>
</profile>
<profile>
<id>run-backend-tests</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludes combine.self="override"/>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
Loading
Loading