Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README languages toggling #1094

Closed
wants to merge 1 commit into from
Closed

Conversation

shemigam1
Copy link

No description provided.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cd90d2) 36.71% compared to head (7551674) 36.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
+ Coverage   36.71%   36.72%   +0.01%     
==========================================
  Files         108      108              
  Lines        8428     8428              
==========================================
+ Hits         3094     3095       +1     
+ Misses       5334     5333       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Jan 8, 2024

Hi, I don't know what it is but it is at least very low quality change. I think you don't know, what the changes are about. I'm sorry for these words, but this can't be merged.

There was an issue about this change, but it's just a proposal with discussion. It waits for @adil192's opinion.

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Jan 8, 2024

Why did you create this, when you can see, there is already a very similar PR #1093?

@adil192 adil192 closed this Jan 9, 2024
@adil192
Copy link
Member

adil192 commented Jan 9, 2024

#1084
Closing this as there are mistakes and it's a very small change that doesn't need a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants