Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard issues #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jasger9000
Copy link
Contributor

@jasger9000 jasger9000 commented Feb 4, 2024

Hello to all,

This PR aims to fix three things:

  1. The keyboard handling for clocking and typing
  2. Removing the duplicated code from the different modes into one file
  3. Making it impossible to input non-valid characters

Closes #36.

This should make it a lot easier to maintain the project (since you don't have to duplicate so much) and decrease its size.
It also is in direct conflict with #34 since we solve the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger key press event on key down instead of key up
1 participant