Fix(Multichain): ignore empty safe address when loading safeOverviews #4289
Conversation
Branch preview✅ Deploy successful! Storybook: |
| const currency = selectCurrency(state as RootState) | ||
|
|
||
| if (!safeAddress) { | ||
| return { data: null } |
There was a problem hiding this comment.
Had to change the return type to null because undefined is not allowed as return type for queryFn
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1004.3 KB (🟡 +49.48 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Fifteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
511 B (🟢 -24.37 KB) |
1004.8 KB |
/address-book |
26.09 KB (🟡 +5 B) |
1.01 MB |
/apps/open |
54.7 KB (-1 B) |
1.03 MB |
/balances |
30.95 KB (🟡 +14 B) |
1.01 MB |
/balances/nfts |
19.18 KB (-1 B) |
1023.49 KB |
/home |
60.54 KB (🟡 +839 B) |
1.04 MB |
/new-safe/advanced-create |
36.49 KB (🟡 +1.36 KB) |
1.02 MB |
/new-safe/create |
35.75 KB (🟡 +1.36 KB) |
1.02 MB |
/new-safe/load |
16.41 KB (🟡 +10 B) |
1020.72 KB |
/settings/modules |
9.79 KB (🟡 +1 B) |
1014.09 KB |
/settings/notifications |
27.03 KB (-1 B) |
1.01 MB |
/settings/setup |
35.98 KB (🟡 +5 B) |
1.02 MB |
/transactions/tx |
21.07 KB (-2 B) |
1 MB |
/welcome |
6.8 KB (🟢 -1 B) |
1011.1 KB |
/welcome/accounts |
379 B (🟢 -1 B) |
1004.67 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Test suite run success1550 tests passing in 206 suites. Report generated by 🧪jest coverage report action from f65cacb |
What it solves
We use
""as fallback value foruseSafeAddress. This caused empty requests to be triggered for the safe overview endpoint.This fixes it by checking the safeAddress parameter before loading the safe overviews.
How to test it
Checklist