-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Poll safe creation info even when switching networks #4294
Conversation
Branch preview✅ Deploy successful! Storybook: |
@@ -189,7 +189,7 @@ const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)) | |||
* @param txHash | |||
* @param maxAttempts | |||
*/ | |||
async function retryGetTransaction(provider: Provider, txHash: string, maxAttempts = 6) { | |||
async function retryGetTransaction(provider: Provider, txHash: string, maxAttempts = 8) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increased this a bit because I saw FAILED events in some cases when it took a bit longer to index a safe.
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
954.87 KB (🟡 +50 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Test suite run success1484 tests passing in 203 suites. Report generated by 🧪jest coverage report action from ebd4125 |
Note: I found an issue that, if you change your network it seems the user is not redirected to the safe. Is an issue already in dev so I created a new ticket for that. |
What it solves
Resolves #4293
How this PR fixes it
chainId
with the SUCCESS and INDEXED safe creation eventHow to test it
Checklist