feat(Queue): add share block to transaction details #4838

iamacook · 2025-01-27T15:45:12Z

What it solves

Improves transaction sharing

How this PR fixes it

Sharing a transaction can assist in signature requests, but the current share button is not super clear.

This adds a new share block to QUEUED MULTISIG transactions according to the designs

How to test it

Each of the following should emit distinctly labelled tracking events:

Open a QUEUED MULTISIG transaction and observe the new share block, with a functioning copy button. When expanding it, an event should also be emitted.
Ensure the existing copy button works and is present on all transaction types.

Screenshots

Checklist

I've tested the branch on mobile 📱
I've documented how it affects the analytics (if at all) 📊
I've written a unit/e2e test for it (if applicable) 🧑‍💻

github-actions · 2025-01-27T15:45:33Z

Branch preview

✅ Deploy successful!

Website:
https://share_block--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://share_block--walletweb.review.5afe.dev/storybook/

notion-workspace · 2025-01-27T15:45:41Z

Add tx copy link for multisig transactions

github-actions · 2025-01-27T15:50:21Z

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1.06 MB` (🟡 +70.63 KB)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/`	`509 B` (🟢 -1 B)	1.06 MB
`/address-book`	`23.21 KB` (🟡 +143 B)	1.08 MB
`/apps`	`35.97 KB` (🟡 +2.25 KB)	1.09 MB
`/apps/custom`	`34.03 KB` (🟡 +2.25 KB)	1.09 MB
`/apps/open`	`55.56 KB` (🟡 +1.95 KB)	1.11 MB
`/balances`	`30.02 KB` (🟡 +320 B)	1.09 MB
`/balances/nfts`	`9.52 KB` (🟢 -23 B)	1.07 MB
`/bridge`	`2.55 KB` (🟢 -5 B)	1.06 MB
`/cookie`	`8.77 KB` (🟡 +1 B)	1.07 MB
`/home`	`61.54 KB` (🟡 +2.28 KB)	1.12 MB
`/licenses`	`2.46 KB` (🟢 -1 B)	1.06 MB
`/new-safe/advanced-create`	`26.38 KB` (🟢 -75 B)	1.08 MB
`/new-safe/create`	`25.52 KB` (🟢 -67 B)	1.08 MB
`/privacy`	`14.57 KB` (🟡 +2 B)	1.07 MB
`/settings/appearance`	`2.25 KB` (🟡 +1 B)	1.06 MB
`/settings/cookies`	`1.87 KB` (🟡 +1 B)	1.06 MB
`/settings/modules`	`4.06 KB` (🟡 +3 B)	1.06 MB
`/settings/notifications`	`6.33 KB` (🟢 -14.98 KB)	1.06 MB
`/settings/safe-apps`	`20.35 KB` (🟡 +2.08 KB)	1.08 MB
`/settings/security`	`2.34 KB` (🟡 +2 B)	1.06 MB
`/settings/setup`	`30.97 KB` (🟡 +246 B)	1.09 MB
`/share/safe-app`	`7.55 KB` (🟢 -8 B)	1.07 MB
`/stake`	`617 B` (🟢 -2 B)	1.06 MB
`/swap`	`763 B` (🟡 +3 B)	1.06 MB
`/terms`	`12.93 KB` (🟡 +1 B)	1.07 MB
`/transactions`	`99.45 KB` (🟡 +2.88 KB)	1.15 MB
`/transactions/history`	`99.41 KB` (🟡 +2.88 KB)	1.15 MB
`/transactions/messages`	`60.25 KB` (🟡 +1.95 KB)	1.12 MB
`/transactions/msg`	`56.5 KB` (🟡 +1.95 KB)	1.11 MB
`/transactions/queue`	`49.36 KB` (🟡 +1.96 KB)	1.11 MB
`/transactions/tx`	`48.72 KB` (🟡 +1.95 KB)	1.11 MB
`/welcome/accounts`	`408 B` (🟡 +1 B)	1.06 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions · 2025-01-27T15:51:48Z

Coverage report for `apps/web`

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	77.47% (-0.02% 🔻)	13875/17911
🔴	Branches	56.8% (-0.03% 🔻)	3492/6148
🟡	Functions	62.76% (-0.06% 🔻)	2086/3324
🟡	Lines	78.89% (-0.02% 🔻)	12519/15869

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / TxShareButton.tsx	80%	100%	0%	80%
🟡	`...` / TxShareBlock.tsx	60%	0%	0%	60%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🟡	`...` / index.tsx	69.64% (+0.55% 🔼)	10% (-0.26% 🔻)	66.67%	70.37% (+0.56% 🔼)
🟡	`...` / index.tsx	64.29% (-4.46% 🔻)	0%	0%	69.23% (-4.1% 🔻)
🟢	`...` / useTxPendingStatuses.ts	77.5% (-0.83% 🔻)	64.06% (-1.56% 🔻)	68.18%	86.41% (-0.97% 🔻)

Test suite run success

1783 tests passing in 240 suites.

Report generated by 🧪jest coverage report action from 20df0b7

katspaugh · 2025-01-28T07:59:05Z

apps/web/src/components/transactions/TxShareLink/TxShareBlock.tsx

+    <Paper className={css.wrapper}>
+      <Accordion className={css.accordion}>
+        <AccordionSummary expandIcon={<ExpandMoreIcon />} className={css.summary}>
+          <Typography className={css.header}>Share link with other owners</Typography>


Suggested change

<Typography className={css.header}>Share link with other owners</Typography>

<Typography className={css.header}>Share link with other signers</Typography>

We've been calling them signers throughout the UI.

Updated in fe946dd.

iamacook · 2025-01-28T09:24:18Z

apps/web/src/components/transactions/TxShareLink/TxShareBlock.tsx

+        </AccordionDetails>
+      </Accordion>
+      <div className={css.copy}>
+        <TxShareLink id={txId} event={TX_LIST_EVENTS.COPY_SHARE_LINK}>


Should this instead be the same event as the button, using a label to differentiate? cc @katspaugh

I would keep a separate event.

Actually the way we've been organising events lately is that each action is linked to a single event, and we use labels to differentiate where the action is done. How this would apply in this case is having an event (e.g. "copy share link") with labels to distinguish between "icon" and "button".

No strong feelings though - so leaving this up to you.

I changed it to use the same event ("Copy deeplink") in 20df0b7 with different labels: button and share-block. The "Open share block" remains though.

katspaugh

👍

tmjssz

LGTM! Just left a small suggestion

tmjssz · 2025-01-28T10:54:21Z

apps/web/src/components/transactions/TxShareLink/index.tsx

This component is only used internally by TxShareBlock/Button right? So maybe as a suggestion we could rename the file to its component name and not be index anymore. Just for consistency, but not blocking

TxShareLink is a wrapper for TxShareBlock and TxShareButton. We could separate them into independant components but I think keeping them together with the wrapper makes sense. What do you think?

Yeah all good then, lets keep them together

liliya-soroka · 2025-01-30T12:56:07Z

Verified
Checked cases:

Tracking
not executed txs in different states of signing
executed txs
nested safes
Chrome, Firefox
Mobal view
diff themes
queued/history and tx details
proposed txs
--
Test cases were created- https://gno.testrail.io/index.php?/suites/view/36&group_by=cases:section_id&group_id=7002&group_order=asc&display_deleted_cases=0

The task to add automation was created - https://github.com/safe-global/safe-test-management/issues/17

feat(Queue): add share block to transaction details

bce108a

iamacook requested a review from tmjssz January 27, 2025 15:45

iamacook self-assigned this Jan 27, 2025

fix(Queue): use different event for share block

878abe9

katspaugh reviewed Jan 28, 2025

View reviewed changes

fix(Queue): rename owners to signers

fe946dd

iamacook requested a review from katspaugh January 28, 2025 08:03

feat(Queue): add event to track expanding block

8bc0493

iamacook commented Jan 28, 2025

View reviewed changes

fix(Queue): change handler property

b19ca0c

katspaugh approved these changes Jan 28, 2025

View reviewed changes

tmjssz approved these changes Jan 28, 2025

View reviewed changes

fix(Queue): use same event with label

20df0b7

iamacook merged commit 61db942 into dev Jan 30, 2025
15 checks passed

iamacook deleted the share-block branch January 30, 2025 12:59

github-actions bot locked and limited conversation to collaborators Jan 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Queue): add share block to transaction details #4838

feat(Queue): add share block to transaction details #4838

iamacook commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

notion-workspace bot commented Jan 27, 2025

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

katspaugh Jan 28, 2025

iamacook Jan 28, 2025

iamacook Jan 28, 2025

katspaugh Jan 28, 2025

alicecha Jan 28, 2025

iamacook Jan 28, 2025

katspaugh left a comment

tmjssz left a comment

tmjssz Jan 28, 2025

iamacook Jan 28, 2025

tmjssz Jan 28, 2025

liliya-soroka commented Jan 30, 2025 •

edited

Loading

	<Typography className={css.header}>Share link with other owners</Typography>
	<Typography className={css.header}>Share link with other signers</Typography>

feat(Queue): add share block to transaction details #4838

feat(Queue): add share block to transaction details #4838

Conversation

iamacook commented Jan 27, 2025 • edited Loading

What it solves

How this PR fixes it

How to test it

Screenshots

Checklist

github-actions bot commented Jan 27, 2025 • edited Loading

Branch preview

notion-workspace bot commented Jan 27, 2025

github-actions bot commented Jan 27, 2025 • edited Loading

📦 Next.js Bundle Analysis for @safe-global/web

⚠️ Global Bundle Size Increased

Thirty-two Pages Changed Size

github-actions bot commented Jan 27, 2025 • edited Loading

Coverage report for apps/web

Test suite run success

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katspaugh left a comment

Choose a reason for hiding this comment

tmjssz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liliya-soroka commented Jan 30, 2025 • edited Loading

iamacook commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

Coverage report for `apps/web`

liliya-soroka commented Jan 30, 2025 •

edited

Loading