Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Featured apps" section to Safe Apps #4468

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Nov 4, 2024

What it solves

Adds a new "Featured apps" section to Safe Apps

How this PR fixes it

A new featured flag is returned with each Safe App.

This adds a new "Featured apps" section above "All apps" on the Safe Apps page. Said section is not shown if there are no featuredApps on the given chain, or there is a search term. Should pinned Apps exist, they are above those featured.

How to test it

  1. On the Safe Apps pane, observing the following:
  • "Featured apps" is only shown if App(s) are featured on the chain
  • "Featured apps" is below "My pinned apps"
  • "Featured apps" is above "All apps"
  • "Featured apps" is not shown if there is a search term
  • "Featured apps" is not shown on the "My custom apps" tab

Note: as of the creation of the PR, Transaction Builder is featured.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from schmanu November 4, 2024 13:17
@iamacook iamacook self-assigned this Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Copy link

Copy link

github-actions bot commented Nov 4, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 48.48 KB (🟡 +53 B) 1.04 MB
/apps/custom 40.07 KB (🟡 +11 B) 1.03 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Nov 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.09% (+0.01% 🔼)
13906/18770
🔴 Branches
52.75% (+0.04% 🔼)
3428/6499
🔴 Functions
57.95% (+0.02% 🔼)
2031/3505
🟡 Lines
75.76% (+0.01% 🔼)
12634/16676

Test suite run success

1593 tests passing in 215 suites.

Report generated by 🧪jest coverage report action from dcf7023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants