SAK-51048 - Send emails asynchronously #13376
Open
+91
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As an FYI, the review is easier to read if you turn off the whitespace changes since the bulk of the edit was just an indentation change. |
ottenhoff
reviewed
Mar 3, 2025
| } | ||
| // Optionally handle exceptions or completion | ||
| future.exceptionally(ex -> { | ||
| log.error("Error occurred while sending email: " + ex.getMessage()); |
There was a problem hiding this comment.
Suggested change
| log.error("Error occurred while sending email: " + ex.getMessage()); | |
| log.error("Error occurred while sending email: {}", ex.toString()); |
|
Awesome. What do you see in your Tomcat log now when sending out hundreds of emails? It's basically instant now to the end user (e.g., the instructor sending hundreds of emails)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.