-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-51080 Duplicate Site: New parameter for title #13377
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
<label for="id"> | ||
$tlang.getString("sittoo.tit") | ||
</label> | ||
<input type="text" name="title" id="title" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that accesslint mentions it, you can also add the same for the id field, thanks!
} | ||
catch (IdUsedException e) | ||
{ | ||
addAlert(state, rb.getFormattedMessage("sitact.thesitid", new Object[]{id})); | ||
return; | ||
} | ||
catch (IdUnusedException e) | ||
{ | ||
addAlert(state, rb.getFormattedMessage("sitact.thesitid", new Object[]{id})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addAlert(state, rb.getFormattedMessage("sitact.thesitid", new Object[]{id})); | |
addAlert(state, rb.getFormattedMessage("sitact.notfound", new Object[]{id})); |
<label for="id"> | ||
$tlang.getString("sittoo.tit") | ||
</label> | ||
<input type="text" name="title" id="title" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that accesslint mentions it, you can also add the same for the id field, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There's one cypress test for announcements failing, but it shouldn't be related. Any clues @ottenhoff ? |
Maybe this one: #13371... |
The problem is with the new announcements cypress test. I will fix it and re-run the test. |
SAK-51080