Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-51080 Duplicate Site: New parameter for title #13377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jumarub
Copy link
Contributor

@jumarub jumarub commented Mar 3, 2025

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<label for="id">
$tlang.getString("sittoo.tit")
</label>
<input type="text" name="title" id="title" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that accesslint mentions it, you can also add the same for the id field, thanks!

}
catch (IdUsedException e)
{
addAlert(state, rb.getFormattedMessage("sitact.thesitid", new Object[]{id}));
return;
}
catch (IdUnusedException e)
{
addAlert(state, rb.getFormattedMessage("sitact.thesitid", new Object[]{id}));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
addAlert(state, rb.getFormattedMessage("sitact.thesitid", new Object[]{id}));
addAlert(state, rb.getFormattedMessage("sitact.notfound", new Object[]{id}));

<label for="id">
$tlang.getString("sittoo.tit")
</label>
<input type="text" name="title" id="title" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that accesslint mentions it, you can also add the same for the id field, thanks!

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

Copy link
Contributor

@bgarciaentornos bgarciaentornos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bgarciaentornos bgarciaentornos requested a review from jesusmmp March 3, 2025 12:07
@bgarciaentornos
Copy link
Contributor

There's one cypress test for announcements failing, but it shouldn't be related. Any clues @ottenhoff ?

@jesusmmp
Copy link
Contributor

jesusmmp commented Mar 3, 2025

There's one cypress test for announcements failing, but it shouldn't be related. Any clues @ottenhoff ?

Maybe this one: #13371...

@bgarciaentornos bgarciaentornos changed the title Duplicate Site: New parameter for title SAK-51080 Duplicate Site: New parameter for title Mar 3, 2025
@ottenhoff
Copy link
Contributor

The problem is with the new announcements cypress test. I will fix it and re-run the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants