@W 13141576 Enable Substitute Function for offline support. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W 13141576 Enable Substitute Function for offline support. 1. Use replaceAll instead of replace in getJavaScript() 2. If arg[1] is null, return null. arg[2] is null use replaceAll(arg[1], ""). else use replaceAll(arg[1], arg[2]) 3. Add test cases. 4. Add isOffline=true annotation
aditya-jain3
requested review from
tushard702,
mayank-lohiya,
ashwanikmr121 and
jainkaran98
|
LGTM, can be pushed after team aligns on [Golden File, File, null] test case |
There was a problem hiding this comment.
@aditya-jain3 Can you please share the coverage numbers as the coverage for this function was not 100% earlier?
sure |
@ashwanikmr121 Currently it's 86% Trying to add 1 more case to increase the coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W 13141576 Enable Substitute Function for offline support.