@W-14371508 fix: JS Substitute function to replace all matches #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashwanikmr121
commented
Mar 13, 2024
•
ashwanikmr121
commented
- Fixed Substitute function to replace all matching keywords
- Use replaceAll instead of replace in getJavaScript()
- Aligned the implementation with formula and sql based executors
- Added test cases.
ashwanikmr121
changed the title
impl/src/main/java/com/force/formula/commands/FunctionSubstitute.java
Outdated
Show resolved
Hide resolved
sahil-here
reviewed
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.