Code

[RFC] fixpoint iteration support#603

Code

Open

carljm wants to merge 51 commits intosalsa-rs:mastersalsa-rs/salsa:masterfrom carljm:fixpointcarljm/salsa:fixpointCopy head branch name to clipboard

+2,194-1,562

Commits

Commits on Dec 16, 2024

• add example test for fixpoint iteration

  carljm

  committed
  3d00ae3

  Copy full SHA for 3d00ae3

• add a multi-symbol test

  carljm

  committed
  31979b9

  Copy full SHA for 31979b9

• simplify test case

  carljm

  committed
  35e236e

  Copy full SHA for 35e236e

• WIP: remove existing cycle handling tests for now

  carljm

  committed
  90ea6e9

  Copy full SHA for 90ea6e9

• WIP: remove all existing cycle handling, add fixpoint options

  carljm

  committed
  f218e58

  Copy full SHA for f218e58

• WIP: added provisional value and cycle fields

  carljm

  committed
  6ce61c6

  Copy full SHA for 6ce61c6

• rename to CycleRecoveryStrategy::Fixpoint

  carljm

  committed
  29d110e

  Copy full SHA for 29d110e

• WIP: rip out ProvisionalValue

  carljm

  committed
  adb6c77

  Copy full SHA for adb6c77

• WIP: working single-iteration with provisional memo

  carljm

  committed
  7f82b6d

  Copy full SHA for 7f82b6d

• WIP: add count arg to cycle_recovery_fn

  carljm

  committed
  a7be3d9

  Copy full SHA for a7be3d9

• WIP: move insert-initial out into fetch_cold

  carljm

  committed
  6c6dd55

  Copy full SHA for 6c6dd55

• WIP: cycle-head iteration

  carljm

  committed
  8974361

  Copy full SHA for 8974361

• WIP: move loop into execute

  carljm

  committed
  797655e

  Copy full SHA for 797655e

• WIP: delay storing memo

  carljm

  committed
  27742a2

  Copy full SHA for 27742a2

• WIP: remove ourself from cycle heads when done iterating

  carljm

  committed
  4f4df72

  Copy full SHA for 4f4df72

• WIP: working convergence and fallback

  carljm

  committed
  315944e

  Copy full SHA for 315944e

• WIP: clippy and cleanup

  carljm

  committed
  28242a4

  Copy full SHA for 28242a4

• WIP: improve comments and add a type annotation

  carljm

  committed
  0be825a

  Copy full SHA for 0be825a

• WIP: don't allow cycle_fn with no_eq

  carljm

  committed
  c3c84c4

  Copy full SHA for c3c84c4

• WIP: add tracing for cycle iteration

  carljm

  committed
  72dff5f

  Copy full SHA for 72dff5f

• WIP: fail fast if we get an evicted provisional value

  carljm

  committed
  6b44c92

  Copy full SHA for 6b44c92

• WIP: use FxHashSet::from_iter

  carljm

  committed
  a029ef4

  Copy full SHA for a029ef4

• add tests, fix multiple-revision, lazy provisional value

  carljm

  committed
  492ae1b

  Copy full SHA for 492ae1b

• review feedback, more tracing

  carljm

  committed
  0f7d940

  Copy full SHA for 0f7d940

• fix multi-revision bug

  carljm

  committed
  5ef7a5f

  Copy full SHA for 5ef7a5f

• better fix for multi-revision bug

  carljm

  committed
  3093460

  Copy full SHA for 3093460

• test fixes

  carljm

  committed
  7d9ec1c

  Copy full SHA for 7d9ec1c

• pass inputs to cycle recovery functions

  carljm

  committed
  aa4a731

  Copy full SHA for aa4a731

• fixed cycle-unchanged test

  carljm

  committed
  67376f1

  Copy full SHA for 67376f1

• add TODO comments for some outstanding questions

  carljm

  committed
  286b5fb

  Copy full SHA for 286b5fb

• add a test for the "AB peeping C" scenario

  

  Niko Matsakis

  authored and

  carljm

  committed
  b2d4d92

  Copy full SHA for b2d4d92

• another parallel test scenario

  

  Niko Matsakis

  authored and

  carljm

  committed
  670f88b

  Copy full SHA for 670f88b

• WIP: removed cycle_ignore; nested cycles broken

  carljm

  committed
  00acc56

  Copy full SHA for 00acc56

Commits on Dec 18, 2024

• fixed all single-thread cycles; multi-thread still not working

  carljm

  committed
  5202579

  Copy full SHA for 5202579

Commits on Jan 14, 2025

• Merge branch 'master' into fixpoint

  Show description for 1dfa978
  carljm

  committed
  1dfa978

  Copy full SHA for 1dfa978

• Merge branch 'master' into fixpoint

  Show description for ea62531
  carljm

  committed
  ea62531

  Copy full SHA for ea62531

Commits on Jan 15, 2025

• panic if fallback fails to converge

  carljm

  committed
  3bf7930

  Copy full SHA for 3bf7930

Commits on Jan 16, 2025

• Merge branch 'master' into fixpoint

  Show description for cec63ba
  carljm

  committed
  cec63ba

  Copy full SHA for cec63ba

Commits on Jan 23, 2025

• all cycle tests passing

  carljm

  committed
  33ac6ac

  Copy full SHA for 33ac6ac

• remove debugging cruft

  carljm

  committed
  e7e511b

  Copy full SHA for e7e511b

• Merge branch 'master' into fixpoint

  Show description for 3f84bae
  carljm

  committed
  3f84bae

  Copy full SHA for 3f84bae

• fix expect message

  carljm

  committed
  68f932a

  Copy full SHA for 68f932a

• revert change to compile-fail test expectation

  carljm

  committed
  2aa0ff0

  Copy full SHA for 2aa0ff0

• a couple optimizations

  carljm

  committed
  3b78901

  Copy full SHA for 3b78901

• construct fewer hash sets

  carljm

  committed
  d6a73a9

  Copy full SHA for d6a73a9

Commits on Jan 24, 2025

• Merge branch 'master' into fixpoint

  Show description for 9cc059b
  carljm

  committed
  9cc059b

  Copy full SHA for 9cc059b

• three-thread cycle test

  carljm

  committed
  7d9ced3

  Copy full SHA for 7d9ced3

Commits on Jan 25, 2025

• Merge branch 'master' into fixpoint

  Show description for d4217ca
  carljm

  committed
  d4217ca

  Copy full SHA for d4217ca

Commits on Jan 28, 2025

• Merge branch 'master' into fixpoint

  Show description for 16d4a49
  carljm

  committed
  16d4a49

  Copy full SHA for 16d4a49

• Merge branch 'master' into fixpoint

  Show description for 3ae4c8a
  carljm

  committed
  3ae4c8a

  Copy full SHA for 3ae4c8a

Commits on Jan 31, 2025

• Merge branch 'master' into fixpoint

  Show description for e659993
  carljm

  committed
  e659993

  Copy full SHA for e659993