Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow overriding interned_sans_lifetime-annotated structs with custom IDs #620

Conversation

davidbarsky
Copy link
Contributor

@davidbarsky davidbarsky commented Dec 3, 2024

(This feature builds atop of #618, but GitHub doesn't do git range-diff between PRs, so...)

This PR adds support for replacing the salsa::Id in #[salsa::interned_sans_lifetime]-annotated structs with a newtype that implements salsa::plumbing::FromId and salsa::plumbing::AsId. I expect that this would simplify migrating rust-analyzer, especially inside of the span crate, as we use bit-packed u32s.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 35fd2af
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/6761984d9eaf540008d123c4

Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #620 will not alter performance

Comparing davidbarsky:davidbarsky/allow-overrriding-ids-in-lifetimeless-interned-structs (35fd2af) with master (3c7f169)

Summary

✅ 9 untouched benchmarks

@davidbarsky davidbarsky force-pushed the davidbarsky/allow-overrriding-ids-in-lifetimeless-interned-structs branch 3 times, most recently from 134212e to 96d26c8 Compare December 5, 2024 16:00
@davidbarsky davidbarsky force-pushed the davidbarsky/allow-overrriding-ids-in-lifetimeless-interned-structs branch from 96d26c8 to 35fd2af Compare December 17, 2024 15:27
@davidbarsky
Copy link
Contributor Author

Closed in favor of #632.

@davidbarsky davidbarsky deleted the davidbarsky/allow-overrriding-ids-in-lifetimeless-interned-structs branch December 18, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant