feature: allow overriding interned_sans_lifetime
-annotated structs with custom IDs
#620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This feature builds atop of #618, but GitHub doesn't do
git range-diff
between PRs, so...)This PR adds support for replacing the
salsa::Id
in#[salsa::interned_sans_lifetime]
-annotated structs with a newtype that implementssalsa::plumbing::FromId
andsalsa::plumbing::AsId
. I expect that this would simplify migrating rust-analyzer, especially inside of thespan
crate, as we use bit-packedu32s
.