Implement self-referential/subset key interning #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #633 will not alter performanceComparing Summary
|
Veykril
changed the title
Veykril
force-pushed
the
veykril/push-xxyqmmxqtpsl
branch
from
3790eb9 to
542c829
Compare
Veykril
force-pushed
the
veykril/push-xxyqmmxqtpsl
branch
from
542c829 to
f2f9e11
Compare
nikomatsakis
approved these changes
Jan 6, 2025
davidbarsky
pushed a commit
to davidbarsky/salsa
that referenced
this pull request
Jan 7, 2025
Implement self-referential/subset key interning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lacks a user facing API via the macro but I could not be bothered implementing that as it takes way too much effort with the decl macro quoting unfortunately (and I did not feel like cloning the entire macro for this either). This is enough for rust-analyzer's needs for the time being though as there is only one usage which we have handwritten for now.