Project/sdc #2
Open
Project/sdc #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified the watch - removing unnecessary logic.
Add new build system to civictheme.
richardgaunt
commented
Jan 6, 2025
|
|
||
| # Copy all files into appllication source directory. Existing files are always | ||
| # overridden. | ||
| COPY . /app | ||
|
|
||
| # Compile front-end assets. Running this after copying all files as we need | ||
| # sources to compile assets. | ||
| RUN cd /app/web/themes/contrib/civictheme && npm run build | ||
| # Install NodeJS dependencies. | ||
| RUN cd /app/web/themes/contrib/civictheme_base && npm run dist |
There was a problem hiding this comment.
Added build step for civictheme_base
richardgaunt
commented
Jan 6, 2025
| @@ -12,6 +12,9 @@ FROM ${CLI_IMAGE:-cli} as cli | |||
| # @see https://github.com/uselagoon/lagoon-images/tree/main/images/php-fpm | |||
| FROM uselagoon/php-8.3-fpm:24.10.0 | |||
|
|
|||
| # @todo fix this for development servers and production | |||
| RUN cp "$PHP_INI_DIR/php.ini-development" "$PHP_INI_DIR/php.ini" | |||
There was a problem hiding this comment.
Needed zend_assertions set to 1 which is on development version of php.ini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Issue #123456 by drupal_org_username: Issue titleChangedsection about WHY something was done if this was not a normal implementationChanged
Screenshots