Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lnav): LNAV Tuning #455

Merged
merged 23 commits into from
Aug 12, 2022
Merged

feat(lnav): LNAV Tuning #455

merged 23 commits into from
Aug 12, 2022

Conversation

747-4EVER
Copy link
Contributor

Changes some values in LNAV director to hopefully improve tracking and turning performance.

INSTRUCTIONS FOR TESTING:

Observe turning performance on ND.

Try to observe across the whole speed range of the aircraft and a range of angles from shallow to sharp turns.

Be mindful when judging performance to check that the turn is actually achievable, i.e abiding by SID/STAR speed restrictions.
Even with the best tracking in the world it will not be possible to complete a turn if you are too fast for a published procedure.

Please provide feedback if you see a trend of undershooting or overshooting and by how much.

Note: The tracking should be improved but will not be 100% accurate. A small error (below 0.5nm or so) on rollout is acceptable as long as the aircraft corrects itself in a timely manner without meandering multiple times around the route.

747-4EVER and others added 21 commits March 14, 2022 16:30
commit 8794e93
Author: Ninjo <[email protected]>
Date:   Fri Apr 15 14:35:15 2022 +0200

    feat(sound): cchord and caution sounds (saltysimulations#429)

commit e417aed
Author: Ninjo <[email protected]>
Date:   Thu Apr 14 23:53:44 2022 +0200

    build: upload fragmenter zip assets to release (saltysimulations#428)

commit 9f3a136
Author: Ninjo <[email protected]>
Date:   Thu Apr 14 22:19:18 2022 +0200

    build: fragmenter script (saltysimulations#427)

commit d83c883
Author: 747-4EVER <[email protected]>
Date:   Thu Apr 14 11:18:48 2022 +0200

    feat(EICAS) New Messages (saltysimulations#424)

commit 942cb62
Author: dcherrie <[email protected]>
Date:   Tue Apr 12 03:32:09 2022 +1000

    feat: update salty livery model, new thumbnails (saltysimulations#420)

commit 366bbc5
Author: Robin Breitfeld <[email protected]>
Date:   Sun Apr 10 22:10:49 2022 +0200

    feat(fmc): VNAV operating altitude suggestion (saltysimulations#419)

    * VNAV climb altitude suggestion

    * remove unnecessary variable

    * update NaN check

    * update max crz altitude formula

    * fix(FMC): Fixed VNAV NaN bug

    * fix(FMC): better aligned text

    Co-authored-by: 747-4EVER <[email protected]>

commit 63347e4
Author: Ninjo <[email protected]>
Date:   Sun Apr 10 22:01:59 2022 +0200

    feat(fmc): improvements to simbrief uplink (saltysimulations#422)

    * feat(fmc): no wpt select on uplink, uplink chime, fixes

    * chore: remove debug stuff and stuff

    * fix: crz alt format on perf init uplink preview
commit 8794e93
Author: Ninjo <[email protected]>
Date:   Fri Apr 15 14:35:15 2022 +0200

    feat(sound): cchord and caution sounds (saltysimulations#429)

commit e417aed
Author: Ninjo <[email protected]>
Date:   Thu Apr 14 23:53:44 2022 +0200

    build: upload fragmenter zip assets to release (saltysimulations#428)

commit 9f3a136
Author: Ninjo <[email protected]>
Date:   Thu Apr 14 22:19:18 2022 +0200

    build: fragmenter script (saltysimulations#427)

commit d83c883
Author: 747-4EVER <[email protected]>
Date:   Thu Apr 14 11:18:48 2022 +0200

    feat(EICAS) New Messages (saltysimulations#424)

commit 942cb62
Author: dcherrie <[email protected]>
Date:   Tue Apr 12 03:32:09 2022 +1000

    feat: update salty livery model, new thumbnails (saltysimulations#420)

commit 366bbc5
Author: Robin Breitfeld <[email protected]>
Date:   Sun Apr 10 22:10:49 2022 +0200

    feat(fmc): VNAV operating altitude suggestion (saltysimulations#419)

    * VNAV climb altitude suggestion

    * remove unnecessary variable

    * update NaN check

    * update max crz altitude formula

    * fix(FMC): Fixed VNAV NaN bug

    * fix(FMC): better aligned text

    Co-authored-by: 747-4EVER <[email protected]>

commit 63347e4
Author: Ninjo <[email protected]>
Date:   Sun Apr 10 22:01:59 2022 +0200

    feat(fmc): improvements to simbrief uplink (saltysimulations#422)

    * feat(fmc): no wpt select on uplink, uplink chime, fixes

    * chore: remove debug stuff and stuff

    * fix: crz alt format on perf init uplink preview
Merge remote-tracking branch 'upstream/master'
commit d5fd734
Author: 747-4EVER <[email protected]>
Date:   Sat Apr 16 12:19:37 2022 +0100

    feat(Sounds) Added C-Chord and Caution Sounds (saltysimulations#431)

    * feat(MCP): Cosmetic Update

    * fix(AP) Fixed TO/GA keybind bug

    * fix(AP): LOC Fix

    * Fix(AP): LOC intercept

    * Squashed commit of the following:

    commit 8794e93
    Author: Ninjo <[email protected]>
    Date:   Fri Apr 15 14:35:15 2022 +0200

        feat(sound): cchord and caution sounds (saltysimulations#429)

    commit e417aed
    Author: Ninjo <[email protected]>
    Date:   Thu Apr 14 23:53:44 2022 +0200

        build: upload fragmenter zip assets to release (saltysimulations#428)

    commit 9f3a136
    Author: Ninjo <[email protected]>
    Date:   Thu Apr 14 22:19:18 2022 +0200

        build: fragmenter script (saltysimulations#427)

    commit d83c883
    Author: 747-4EVER <[email protected]>
    Date:   Thu Apr 14 11:18:48 2022 +0200

        feat(EICAS) New Messages (saltysimulations#424)

    commit 942cb62
    Author: dcherrie <[email protected]>
    Date:   Tue Apr 12 03:32:09 2022 +1000

        feat: update salty livery model, new thumbnails (saltysimulations#420)

    commit 366bbc5
    Author: Robin Breitfeld <[email protected]>
    Date:   Sun Apr 10 22:10:49 2022 +0200

        feat(fmc): VNAV operating altitude suggestion (saltysimulations#419)

        * VNAV climb altitude suggestion

        * remove unnecessary variable

        * update NaN check

        * update max crz altitude formula

        * fix(FMC): Fixed VNAV NaN bug

        * fix(FMC): better aligned text

        Co-authored-by: 747-4EVER <[email protected]>

    commit 63347e4
    Author: Ninjo <[email protected]>
    Date:   Sun Apr 10 22:01:59 2022 +0200

        feat(fmc): improvements to simbrief uplink (saltysimulations#422)

        * feat(fmc): no wpt select on uplink, uplink chime, fixes

        * chore: remove debug stuff and stuff

        * fix: crz alt format on perf init uplink preview

    * feat(Sounds): Added C-Chord and Caution Sound

commit 1f4fde8
Author: 747-4EVER <[email protected]>
Date:   Fri Apr 15 23:24:19 2022 +0100

    fix(mcp): MCP Fixes (saltysimulations#432)

    * fix(FMC): Fixed POS page 4

    * fix(FMC): Fixed flight phase sequencing

    * Squashed commit of the following:

    commit ba4bc9d
    Author: Ninjo <[email protected]>
    Date:   Fri Apr 15 19:13:58 2022 +0200

        fix(sounds): c chord volume (saltysimulations#430)

    commit 8794e93
    Author: Ninjo <[email protected]>
    Date:   Fri Apr 15 14:35:15 2022 +0200

        feat(sound): cchord and caution sounds (saltysimulations#429)

    commit e417aed
    Author: Ninjo <[email protected]>
    Date:   Thu Apr 14 23:53:44 2022 +0200

        build: upload fragmenter zip assets to release (saltysimulations#428)

    commit 9f3a136
    Author: Ninjo <[email protected]>
    Date:   Thu Apr 14 22:19:18 2022 +0200

        build: fragmenter script (saltysimulations#427)

    commit d83c883
    Author: 747-4EVER <[email protected]>
    Date:   Thu Apr 14 11:18:48 2022 +0200

        feat(EICAS) New Messages (saltysimulations#424)

    commit 942cb62
    Author: dcherrie <[email protected]>
    Date:   Tue Apr 12 03:32:09 2022 +1000

        feat: update salty livery model, new thumbnails (saltysimulations#420)

    commit 366bbc5
    Author: Robin Breitfeld <[email protected]>
    Date:   Sun Apr 10 22:10:49 2022 +0200

        feat(fmc): VNAV operating altitude suggestion (saltysimulations#419)

        * VNAV climb altitude suggestion

        * remove unnecessary variable

        * update NaN check

        * update max crz altitude formula

        * fix(FMC): Fixed VNAV NaN bug

        * fix(FMC): better aligned text

        Co-authored-by: 747-4EVER <[email protected]>

    commit 63347e4
    Author: Ninjo <[email protected]>
    Date:   Sun Apr 10 22:01:59 2022 +0200

        feat(fmc): improvements to simbrief uplink (saltysimulations#422)

        * feat(fmc): no wpt select on uplink, uplink chime, fixes

        * chore: remove debug stuff and stuff

        * fix: crz alt format on perf init uplink preview

    commit fefd120
    Author: 747-4EVER <[email protected]>
    Date:   Tue Apr 5 23:09:08 2022 +0200

        Fix(AP): LOC intercept (saltysimulations#418)

        * Fix(AP): LOC intercept

    commit e150e55
    Author: Ninjo <[email protected]>
    Date:   Tue Apr 5 21:44:21 2022 +0200

        chore: hard-fork (saltysimulations#402)

    commit 4991807
    Author: 747-4EVER <[email protected]>
    Date:   Tue Apr 5 20:30:37 2022 +0200

        AP LOC fix (saltysimulations#417)

        * fix(AP): LOC Fix

    commit 1e01a99
    Author: Ninjo <[email protected]>
    Date:   Sat Apr 2 21:47:49 2022 +0200

        fix: nan in fmc vnav and legs pages when no crz alt set (saltysimulations#415)

    commit 8ca5c8e
    Author: iamdumdum1234 <[email protected]>
    Date:   Sat Apr 2 22:12:56 2022 +0700

        fix(fmc): Inhibit VNAV when there is no CRZ ALT + ETA in POS Report fix (saltysimulations#414)

    commit cb0f445
    Author: 747-4EVER <[email protected]>
    Date:   Sat Apr 2 16:25:02 2022 +0200

        feat(AP) ILS improvements (saltysimulations#403)

        * Initial Commit

        * Bug Fixes

        * fix(AP): fixed AFDS Inhibits

        * feat(AP): Enabled SPD switch

        * fix(AP): SPD now activates automatically on GS capture

        * fix(AT): Fixed Auto Idle during TO/GA

        * Bug Fixes

    commit 179d0f8
    Author: 747-4EVER <[email protected]>
    Date:   Sun Mar 27 13:48:36 2022 +0100

        fix(fmc): Fixed POS page 4 & Flightphase sequencing (saltysimulations#407)

    commit ad1545e
    Author: 747-4EVER <[email protected]>
    Date:   Sun Mar 27 13:48:20 2022 +0100

        feat(debug): AP Debug Page (saltysimulations#408)

    commit 62cbc51
    Author: Robin Breitfeld <[email protected]>
    Date:   Sun Mar 27 13:18:50 2022 +0200

        feat(fmc): t/d indication in progress page + unit conversion fix (saltysimulations#385)

    commit 5d10e5d
    Author: 747-4EVER <[email protected]>
    Date:   Thu Mar 24 22:30:04 2022 +0000

        fix(AP) Fixed TO/GA keybind. (saltysimulations#404)

        * feat(MCP): Cosmetic Update

        * fix(AP) Fixed TO/GA keybind bug

    commit 2f0cf18
    Author: 747-4EVER <[email protected]>
    Date:   Thu Mar 24 22:28:45 2022 +0000

        feat(EFIS) : Visual update (saltysimulations#405)

    commit 72fdb8a
    Author: 747-4EVER <[email protected]>
    Date:   Thu Mar 24 22:27:47 2022 +0000

        fix(Model) Reverts Wipers to working Asobo state (saltysimulations#406)

    commit 2b3c14e
    Author: Ninjo <[email protected]>
    Date:   Tue Mar 22 21:07:43 2022 +0100

        fix(fmc): duped waypoints on repeated waypoint selection (saltysimulations#412)

    commit 00462a9
    Author: Giridhar Raut <[email protected]>
    Date:   Tue Mar 22 22:33:24 2022 +0530

        fix(model): bank angle selector set to auto by default (saltysimulations#411)

    * fix(AP) MCP Fixes
@TJCAviation
Copy link

Name: Tobias J Cook#6576
Date of testing: Current date 30/06/2022
Version of the sim: Latest version
PR Tested: #455

Steps you've made to test the Pull Request:

Select Salty 747 in Aircraft Selection
Flew a normal flight plan entered via simbrief
observed LNAV accuracy via Navigraph Charts app and volanta.
Overall Rating: Passed
Conclusions of the testing: LNAV is better than before , slight overshoots here and there but 9/10 it is bang on. Image below shows the worst overshoot I had, and it still wasn't that bad

image

@ninjomcs ninjomcs changed the title LNAV Tuning feat(lnav): LNAV Tuning Aug 11, 2022
@brewers10
Copy link

Name: brewers_10#5706
Date of testing: 11/08/2022
Version of the sim: Latest Version of Sim Update 9
PR Tested: #445

Testing technique: Loaded into Birmingham (EGBB) runway 33. Flight from EGBB --> EGCC. ADMEX1M departure and HON1H hotel arrival. A good variety of turns at differing speeds so perfect for testing LNAV.

Steps you've made to test the Pull Request:

  1. Loaded into EGBB
  2. Loaded the ADMEX1M and HON1H SID and STAR into the FMC
  3. Departed EGBB
  4. Observed how well the LNAV coped with the initial climb out then right hand loop toward ADMEX.
  5. Entered the HON1H arrival into EGLL, observed how the LNAV coped with the twists and turns into London.

Overall Rating: Good
Conclusions of the testing: Tended to not work so well at slow speeds (such as after passing Bovingdon for the approach). Other than that really impressed.

NOTE: Speeds were inputted according to the charts. 220 knots on the initial turn. 250 knots on the turn from ADMEX. 220 at BNN and then I manually reduced speed as though I were being vectored by ATC.

NOTE 2: Video time-lapse available of entire flight on the link; with enlarged display. Please slow the video down to get the details :) -->
https://clipchamp.com/watch/itByVdHsUHD

@747-4EVER 747-4EVER merged commit 2058dd9 into saltysimulations:master Aug 12, 2022
@DesertRick13
Copy link

Quick hop from TJSJ to TNCC. Much smoother turning from one waypoint to another. However, for some reason, LNAV cut out at about 120NM from TNCC. LNAV was still indicated, and there were no discontinuities. After selecting heading to return to the LNAV path, LNAV took back over when it should have, and flight continued on without further incident. I will try on another flight to see if this reoccurs or is simply a one-off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants