Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4485: add accent view to SegmentItem #1793

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

PLASMA-4485: add accent view to SegmentItem #1793

wants to merge 3 commits into from

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Feb 24, 2025 •
edited by Salute-Eva
Loading

Core

Segment

  • добавлен view=''accent для SegmentItem

What/why changed

Добавлен view=''accent для SegmentItem

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Feb 24, 2025
@TitanKuzmich TitanKuzmich requested a review from Irinkv February 24, 2025 14:35
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1793/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-1793/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1793/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1793/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-1793/giga-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1793/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1793/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1793/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1793/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1793/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1793/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1793/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1793/ui-storybook/

@TitanKuzmich TitanKuzmich marked this pull request as ready for review February 26, 2025 08:47
@github-actions github-actions bot requested review from iljs and vadim-kudr and removed request for Yeti-or, Yakutoc, neretin-trike and shuga2704 February 26, 2025 08:47
@TitanKuzmich TitanKuzmich requested review from denivladislav and removed request for iljs February 26, 2025 09:01
denivladislav
denivladislav reviewed Feb 26, 2025
View reviewed changes
packages/plasma-new-hope/src/examples/plasma_b2c/components/Segment/Segment.stories.tsx
@@ -16,7 +16,7 @@ import { SegmentItem, SegmentGroup } from './Segment';
const contentLeftOptions = ['none', 'icon'];
const contentRightOptions = ['none', 'text', 'counter', 'icon'];

const segmentItemViews = ['default', 'secondary'];
const segmentItemViews = ['default', 'secondary', 'accent'];
Copy link
Contributor

@denivladislav denivladislav Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А тут clear не нужен? В других plasma-сторях есть

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denivladislav denivladislav denivladislav approved these changes

@Irinkv Irinkv Irinkv approved these changes

@vadim-kudr vadim-kudr Awaiting requested review from vadim-kudr

Assignees

@TitanKuzmich TitanKuzmich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanKuzmich @denivladislav @Irinkv