Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook video #596

Closed
wants to merge 43 commits into from
Closed

Facebook video #596

wants to merge 43 commits into from

Conversation

abetis
Copy link
Contributor

@abetis abetis commented Dec 2, 2017

This PR includes Facebook video support.

  • Additional FB video button
  • UTs added

Thoughts:
If other video providers are added (Vimeo?), it will probably be wiser to have one button for video addition, that will open a drop down list where user could select the video provider...

ie [size=150] means 150% of the current font size
it creates a non needed element with the space after the marker is
removed, and that cause the following text to remove the trailing spaces,
while those should be there since the marker space is not shown
Will allow access to youtube video parameters
Youtube command now uses the template and options.
Proper list represenstation in the editor.
# Conflicts:
#	src/formats/bbcode.js
#	src/lib/defaultOptions.js
#	src/lib/templates.js
List type "none" rmeoved, whoever needs it could add via the configuration.
@abetis
Copy link
Contributor Author

abetis commented Apr 16, 2018

Replaced by #694

@abetis abetis closed this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant