-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced lists plugin implementation #690
base: master
Are you sure you want to change the base?
Conversation
Please do not link to w3schools. Those guys are too money hungry compared to the actual help they provide. w3s don't care about standards until it hurts their income. They also don't participate in the standards definitions and don't care to link to the official documentation at w3's website. |
I don't care. Both provide free information on the web. w3 looks more simple to understand. |
Because you don't care, I updated for you. |
* new lines in their own list item. | ||
* See issue #359 | ||
*/ | ||
function fixFirefoxListBug(editor) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What prevents you from making an algorithm that works on all browsers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I follow the original list commands implementation:
// START_COMMAND: Bullet List
bulletlist: {
exec: function () {
fixFirefoxListBug(this);
this.execCommand('insertunorderedlist');
},
tooltip: 'Bullet list'
},
// END_COMMAND
// START_COMMAND: Ordered List
orderedlist: {
exec: function () {
fixFirefoxListBug(this);
this.execCommand('insertorderedlist');
},
tooltip: 'Numbered list'
},
// END_COMMAND
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
Added alternative lists logic from #592 |
The plugin implement:
https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-type