-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create anchor target type plugin for xhtml #844
base: master
Are you sure you want to change the base?
feat: Create anchor target type plugin for xhtml #844
Conversation
I was struggling to assign an icon to replace the |
Hey @samclarke, please let me know if this format is okay as a plugin |
Hey @samclarke, hope you're doing well. Was just wondering if this PR is okay for the next minor version for a plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It looks good! Sorry for the delay in reviewing it.
Could you revert the package-lock.json
file to the master branch version? The default behaviour of npm install
annoyingly rewrites (have to use npm ci
to avoid that).
@@ -1195,6 +1195,11 @@ | |||
attr(node, 'target', target); | |||
} | |||
|
|||
if (target === '_self' || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth adding a check to see if this plugin is loaded as we probably don't want to allow other targets if it isn't.
There isn't a way to check from here as the converters don't have access to have but could check for if this plugin exists:
if (sceditor.plugins.anchortarget ...
Any update on it ? And it's possible to add it too in bbcode? |
Add support for target type in anchor tag xhtml
To support target type in xhtml links