-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Decreased sensitivity and inverted scroll on volume slider (scroll up…
… to increase, down to decrease)
- Loading branch information
Sam Potts
committed
May 19, 2016
1 parent
1496b21
commit 98e4c5a
Showing
5 changed files
with
19 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98e4c5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the page on https://plyr.io/ up to date? Because there when I scroll up the volume decreases... It's totally reversed.
98e4c5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it's the OS X vs Windows thing I think. I'll have to see if I can detect whether the UA is OSX and has the "Natural scroll" enabled.
98e4c5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was Ubuntu, I'll try in Windows tonight :)
98e4c5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a fix so https://plyr.io should be ok now on all apart from Chrome on OS X if the user has natural scroll enabled. Unfortunately there's no way to detect natural scroll is enabled in anything other than Safari (although it's been proposed). Anyhow, Windows, Linux etc should all be correct now.