Code

Video trimming UI plugin#1798

Code

Open

DanielHuntleySBG wants to merge 24 commits intosampotts:developsampotts/plyr:developfrom SBGSports:video-trimming-pluginSBGSports/plyr:video-trimming-pluginCopy head branch name to clipboard

+619-1

Commits

Commits on Apr 2, 2020

• Structural code for video trimming UI

  Danielh112

  committed
  ba312b2

  Copy full SHA for ba312b2

• Merge remote-tracking branch 'origin/develop' into video-trimming-plugin

  Danielh112

  committed
  72f1568

  Copy full SHA for 72f1568

Commits on Apr 3, 2020

• Trim tool icons added

  DanielHuntleySBG

  committed
  4c75bcc

  Copy full SHA for 4c75bcc

• If the user is using the trimming tool, check if the seek position is outside of the trimming region and set to the start of the trimming region

  DanielHuntleySBG

  committed
  c82fa73

  Copy full SHA for c82fa73

Commits on Apr 4, 2020

• Improved styling of Trimming timeline

  DanielHuntleySBG

  committed
  f5bc729

  Copy full SHA for f5bc729

• Fix to only update the current time when the user has finished setting the trimming length (let go of trimming handle)

  DanielHuntleySBG

  committed
  13d15b6

  Copy full SHA for 13d15b6

Commits on Apr 5, 2020

• Trimming tool: Implementation of timestamp above each thumb to display the seek position in the video | Trim plugin is also brought to be more inline with the existing code base (sass structure and…

  Show description for ef5bccf
  DanielHuntleySBG

  committed
  ef5bccf

  Copy full SHA for ef5bccf

Commits on Apr 6, 2020

• Improve accessiblity: Inclusion of aria metadata

  DanielHuntleySBG

  committed
  d8ae6e2

  Copy full SHA for d8ae6e2

• Nit pick fixes for trimming tool PR

  DanielHuntleySBG

  committed
  c9f8329

  Copy full SHA for c9f8329

• Remove plyr.svg from pull request

  DanielHuntleySBG

  authored
  5780e0d

  Copy full SHA for 5780e0d

• Trimming: On source change update whether or not to show the trimming tool

  DanielHuntleySBG

  committed
  e13be14

  Copy full SHA for e13be14

• Merge branch 'video-trimming-plugin' of https://github.com/SBGSports/plyr into video-trimming-plugin

  DanielHuntleySBG

  committed
  5bb96f3

  Copy full SHA for 5bb96f3

Commits on Apr 7, 2020

• Video trimming bug fix: When switching sources a new trimming object was not created | We should only display the trim thumb time tooltip when displaying preview thumbnails as a seek tooltip is dis…

  Show description for 2ab8a88
  DanielHuntleySBG

  committed
  2ab8a88

  Copy full SHA for 2ab8a88

Commits on Apr 8, 2020

• Trimming: Change structure of triggerevent messages so that they are in the correct format and pass a valid element

  DanielHuntleySBG

  committed
  c0fa6d5

  Copy full SHA for c0fa6d5

Commits on Apr 9, 2020

• Remove Timeupdate event listener when changing source as two instances existed causing issues

  DanielHuntleySBG

  committed
  81d77eb

  Copy full SHA for 81d77eb

• Convert the default trim length to percent as for longer videos it was showing only a very small region

  DanielHuntleySBG

  committed
  ee73dc4

  Copy full SHA for ee73dc4

• Addition of a couple additional api endpoints to get and set the start and end points of the trimming range

  DanielHuntleySBG

  committed
  5e53137

  Copy full SHA for 5e53137

• Update to use the existing clamp function | Improve commenting for setting the trim length | Prevent the end value of the trimming region from being before the start

  DanielHuntleySBG

  committed
  83ab236

  Copy full SHA for 83ab236

Commits on Apr 14, 2020

• Remove getter and setter for trimming from plyr.js as it can be accessed via the trimming object and update documentation

  DanielHuntleySBG

  committed
  bc2fbc4

  Copy full SHA for bc2fbc4

• Remove settrimstart and settrimend from plyr.js as they can be set from the trim class: unsure whether a setter should exist for both of these and what its naming convention would be, so have kept …

  Show description for bdf4718
  DanielHuntleySBG

  committed
  bdf4718

  Copy full SHA for bdf4718

• Calling trim.enter or trim.exit did not update the video trim control so have moved the logic to inside the enter and exit function | Additionally removed toggling trimming from plyr.js as it can a…

  Show description for 04941a0
  DanielHuntleySBG

  committed
  04941a0

  Copy full SHA for 04941a0

Commits on Apr 20, 2020

• Fix to Trimming tool, to prevent the start time being before the end time

  DanielHuntleySBG

  committed
  64dc1fd

  Copy full SHA for 64dc1fd

Commits on Apr 24, 2020

• Merge develop branch back into video trimming branch

  DanielHuntleySBG

  committed
  6f06907

  Copy full SHA for 6f06907

Commits on Nov 16, 2020

• resolve merge conflicts

  DanielHuntleySBG

  committed
  3aed88e

  Copy full SHA for 3aed88e