Merged
[email protected] #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
force-pushed
the
dc-sanctuary-def
branch
from
e5d333e to
3df0432
Compare
|
Any particular reason to favour |
| @@ -58,7 +58,7 @@ setup: | |||
|
|
|||
| .PHONY: test | |||
| test: | |||
| $(ISTANBUL) cover node_modules/.bin/_mocha -- --recursive | |||
| $(ISTANBUL) cover node_modules/.bin/_mocha -- --recursive --timeout 10000 | |||
There was a problem hiding this comment.
Two tests timed out in https://circleci.com/gh/sanctuary-js/sanctuary/999.
There was a problem hiding this comment.
Interesting, I've seen these failures locally and just thought it was to do with the terrible laptop I'm using.
Nope. They work equally well in these cases. I decided to make the easy change as many occurrences of |
|
Cool. I just thought I might be missing something! |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanctuary-js/sanctuary-def#72