-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for document filters #423
Conversation
Add document filter class Started work More progress More progress Making progress Making progress Making progress First full run Add color override and documentation
Add color syntax examples
README: double quote closing missing after "black on |
Thanks for the eagle eye on the readme. Should be fixed now. Re: safe area, I think I need to better understand the use case to have an opinion -- happy to have a side discussion on the topic. At a high-level, I do not think safe area should be set to accommodate a specific set of devices. Device limitation/idiosyncrasies should be handled at the device by the player, with the understanding that some reasonable safe area exists. Makes sense? In the meantime, I suggest we merge the PR as-is and iterate, if needed, before the next release. |
OK, that's fine. I mean merge and even release. I will wait strong confirmed needs before asking additionnal features. |
tt convert -i <.scc file> -o <.ttml file> --itype SCC --otype TTML --filter lcd --config '{"general": {"progress_bar":false, "log_level":"WARN"}, "lcd": {"bg_color": "blue"}}'
Closes #417