-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 sangria-akka-http -> sangria-http & subprojects #12
base: main
Are you sure you want to change the base?
Conversation
Good stuff! Would this end up prompting renaming the project from One of the things I've been trying to work around is how to remain agnostic around which http library and json library are used, since akka-http+circe is distinct from http4s+circe, but a lot of the core stuff (instances and whatnot) is similar. Maybe I don't know if the problems Sangria has have enough overlap in this way to be a useful observation |
Hey @blast-hardcheese that's some of the hope. You can see |
akka/build.sbt
Outdated
"com.typesafe.akka" %% "akka-stream-testkit" % akkaVersion, | ||
"com.typesafe.akka" %% "akka-http-testkit" % akkaHttpVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
% Test
?
Doesn't |
At this point, might be less hassle if we push #14 before this. |
@nickhudkins I really like this change, and would like to add more support, like for http4s. |
This is an attempt to move this repo towards
sangria-http
with sub projects providing specific implementations of each piece. It is currently just opened for discussion.The following convention is used:
sangria-http-${HttpFramework}-${SerializationLibrary}
sangria-http
sangria-http-akka
sangria-http-akka-circe