Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 sangria-akka-http -> sangria-http & subprojects #12

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nickhudkins
Copy link
Contributor

@nickhudkins nickhudkins commented Aug 23, 2021

This is an attempt to move this repo towards sangria-http with sub projects providing specific implementations of each piece. It is currently just opened for discussion.

The following convention is used: sangria-http-${HttpFramework}-${SerializationLibrary}

sangria-http
sangria-http-akka
sangria-http-akka-circe

@blast-hardcheese
Copy link

Good stuff! Would this end up prompting renaming the project from sangria-akka-http to sangria-http?

One of the things I've been trying to work around is how to remain agnostic around which http library and json library are used, since akka-http+circe is distinct from http4s+circe, but a lot of the core stuff (instances and whatnot) is similar. Maybe sangria-akka-http, sangria-circe, and sangria-akka-http-circe to tie them together?

I don't know if the problems Sangria has have enough overlap in this way to be a useful observation

@nickhudkins
Copy link
Contributor Author

Hey @blast-hardcheese that's some of the hope. You can see sangria-marshalling-api is the inspiration here. sangria-circe simply fills in an implementation of the sangria-marshalling-api. My hope here is that sangria-http would potentially serve a very similar thing. sangria-http-akka would fill in the akka specific impl, and then sangria-http-akka-circe would take sangria-circe and circe and akka-http to all be tied together

akka/build.sbt Outdated
Comment on lines 8 to 9
"com.typesafe.akka" %% "akka-stream-testkit" % akkaVersion,
"com.typesafe.akka" %% "akka-http-testkit" % akkaHttpVersion

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% Test ?

@performantdata
Copy link

Doesn't playground.html belong in core?

@performantdata
Copy link

At this point, might be less hassle if we push #14 before this.

@yanns
Copy link
Contributor

yanns commented Sep 28, 2022

@nickhudkins I really like this change, and would like to add more support, like for http4s.
Would you have the energy to fix all conflicts and push this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants