-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In the previous implementation `firewall.AccessList` would inherit from `l3.AccessList` which inherited from `base.Base`. `firewall.AccessList` also inherited from `firewall.FirewallPolicyObject`. That lead to a Diamond Shaped inheritance. The fact that `FirewallPolicyObject` and `l3.AccessList` had constructors with different arguments made it difficult to let `super()` call the constructors with different arguments. To resolve that, the diamond Shaped inheritance was resolved making it clearer which `__init__`'s `super()` calls which superclasses constructor. The different signatures of the constructor still pose a problem, hence we send all supplemental arguments of a constructor to `**kwargs`.
- Loading branch information
1 parent
aa54681
commit 7a6528a
Showing
3 changed files
with
9 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters