Fwaas fix protocol any #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a little cleanup before the patch.
If the user specifies protocol any via the FWaaS OpenStack API we end up
with a rule having protocol None. With the old behavior this results in
an empty protocol field, which is not accepted by our hardware router.
Hence, we have to provide a protocol for the ACL. If we don't want to
specify an protocol (tcp, udp, icmp), we need to specify the address
family ("ip") instead, so we now default to that value.
Leaving out the protocol tag from the netconf yang, does not work. It is
accepted by the device (i.e. the YANG stack), but with the empty
protocol field, the YANG stack replaces this with the value "any" (which
I would have done as well if I hadn't read the Cisco device help) and
the IOS-XE cli does not accept any as a valid value here, resulting in a
<bad-cli> error.
mutax
approved these changes
Jan 14, 2025
rhalina
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user specifies protocol any via the FWaaS OpenStack API we end up
with a rule having protocol None. With the old behavior this results in
an empty protocol field, which is not accepted by our hardware router.
Hence, we have to provide a protocol for the ACL. If we don't want to
specify an protocol (tcp, udp, icmp), we need to specify the address
family ("ip") instead, so we now default to that value.
Leaving out the protocol tag from the netconf yang, does not work. It is
accepted by the device (i.e. the YANG stack), but with the empty
protocol field, the YANG stack replaces this with the value "any" (which
I would have done as well if I hadn't read the Cisco device help) and
the IOS-XE cli does not accept any as a valid value here, resulting in a
error.