Fix multiline string emit. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `|-` instead of `|` when there is not a trailing newline in the string value.
davvid
reviewed
Jul 7, 2024
davvid
requested changes
Jul 7, 2024
|
For some reason, I hadn't noticed you opened a PR on saphyr as well. Thanks! <3 @davvid I ported the few style changes you requested to |
davvid
reviewed
Jul 9, 2024
| emitter.dump(original).unwrap(); | ||
|
|
||
| let documents = Yaml::load_from_str(&emitted).unwrap(); | ||
| println!("emitted {emitted}"); |
There was a problem hiding this comment.
was this a leftover debugging println or is this here for future debugging purposes? just checking in case we should trim it.
There was a problem hiding this comment.
I am not against keeping it anyway. They are captured by cargo test and discarded unless the test fails.
Our test suite takes ~0.2s on my machine to run so we can afford a little bit of extra debugging detail should something fail in the future.
davvid
approved these changes
Jul 9, 2024
|
Thank you! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
|-instead of|when there is not a trailing newline in the string value.