Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usage of docker.up #97

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Improve usage of docker.up #97

merged 1 commit into from
Aug 13, 2024

Conversation

TheSuperiorStanislav
Copy link
Member

@TheSuperiorStanislav TheSuperiorStanislav commented Aug 9, 2024 •
edited
Loading

  • Make wait_for_database as task
  • Make docker.up check for compose file
  • Make pytest.run, celery.run use docker.up

Closes #80

@TheSuperiorStanislav TheSuperiorStanislav marked this pull request as ready for review August 9, 2024 13:42
@TheSuperiorStanislav TheSuperiorStanislav requested a review from a team as a code owner August 9, 2024 13:42
ron8mcr
ron8mcr approved these changes Aug 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@TheSuperiorStanislav TheSuperiorStanislav merged commit a623458 into main Aug 13, 2024
3 checks passed
@TheSuperiorStanislav TheSuperiorStanislav deleted the improve-docker-usage branch August 13, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ron8mcr ron8mcr ron8mcr approved these changes

@AndyGreenwell94 AndyGreenwell94 Awaiting requested review from AndyGreenwell94 AndyGreenwell94 is a code owner automatically assigned from saritasa-nest/saritasa-python-squad-team-leads

@NikAzanov NikAzanov Awaiting requested review from NikAzanov NikAzanov is a code owner automatically assigned from saritasa-nest/saritasa-python-squad-team-leads

@khangnguyen090999 khangnguyen090999 Awaiting requested review from khangnguyen090999 khangnguyen090999 is a code owner automatically assigned from saritasa-nest/saritasa-python-squad-team-leads

@KhoiCaoSaritasa KhoiCaoSaritasa Awaiting requested review from KhoiCaoSaritasa KhoiCaoSaritasa is a code owner automatically assigned from saritasa-nest/saritasa-python-squad-team-leads

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wait_for_database cause errors if environment is local (without docker)
2 participants
@TheSuperiorStanislav @ron8mcr