Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discretization renaming #1

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Discretization renaming #1

merged 2 commits into from
Dec 21, 2024

Conversation

satfra
Copy link
Owner

@satfra satfra commented Dec 21, 2024

Fixed

  • There was a bug with TaskFlow internally in deal.ii. Fixed for now by simply disabling taskflow in deal.ii.
  • deal.ii changed its interface for dealii::SolutionTransfer. Adapted the corresponding methods.

Changed

  • The FlowingVariables classes are now in separate namespaces. For finite elements, use DiFfRG::FE::FlowingVariables, for pure variable systems use DiFfRG::FlowingVariables.

Franz R. Sattler added 2 commits December 18, 2024 14:38
created a finite volume discretization
437f57e
fix: bug in deal.ii, fixed by disabling taskflow in deal.ii
5610fd1 
fix: SolutionTransfer has now a different interface, adapted it
feat: FlowingVariables for different discretizations

!FlowingVariables->FE::FlowingVariables

Signed-off-by: Franz R. Sattler <[email protected]>
@satfra satfra merged commit 2db9e98 into main Dec 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@satfra