Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag patches #148

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Tag patches #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45d19b6
fix: add spacing at the bottom of the tags collapse section to avoid …
budak7273 Jan 6, 2024
6417819
fix: remove forced period at end of tag descriptions
budak7273 Jan 6, 2024
d546545
chore: switch tag data binding to use tag id
budak7273 Jan 6, 2024
c26f639
chore: fix hover-tags saying you should click on them in browser titl…
budak7273 Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/components/mods/ModGrid.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
</div>
</div>
{#if tagsOpen}
<div class="flex flex-grow flex-row flex-wrap items-center justify-center gap-1">
<div class="flex flex-grow flex-row flex-wrap items-center justify-center gap-1 pb-10">
{#if $allTags.error}
<p>Oh no... {$allTags.error.message}</p>
{:else if !$allTags.fetching}
Expand Down
9 changes: 5 additions & 4 deletions src/lib/components/utils/TagDisplay.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,21 @@

$: popupHover = {
event: popupTriggerEvent,
target: `popupHoverFor${tag.name}`,
target: `popupHoverFor${tag.id}`,
placement: 'bottom-start'
} satisfies PopupSettings;
</script>

<div
class="lowercase text-neutral-300 [&>*]:pointer-events-none"
use:popup={popupHover}
title="Click for tag information">
title={popupTriggerEvent === 'click' ? 'Click for tag information' : ''}>
<span class="text-orange-500">#</span>{tag.name}
</div>

<!-- Must use high z-index to ensure it draws on top of things like striped compatibility overlays in mod cards -->
<!-- For some reason this still isn't able to draw over the ModGrid paginator-->
<!-- https://floating-ui.com/docs/misc#z-index-stacking -->
<div class="card variant-filled-surface p-4" data-popup={`popupHoverFor${tag.name}`} style="z-index: 1000">
<p>{tag.description}.</p>
<div class="card variant-filled-surface p-4" data-popup={`popupHoverFor${tag.id}`} style="z-index: 1000">
<p>{tag.description}</p>
</div>
Loading