Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support setting reporters for TestCafe #832

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Sep 7, 2023

Proposed changes

This PR should be merged&released after saucelabs/sauce-testcafe-runner#197 release. It's for adding configFile setting to testcafe section.

Without this change, TestCafe can still pick up default config files which are .testcaferc.json, .testcaferc.js, .testcaferc.cjs.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@tianfeng92 tianfeng92 added the enhancement New feature or request label Sep 7, 2023
@tianfeng92 tianfeng92 changed the title feat: Support setting reporters for TestCafe HOLD: feat: Support setting reporters for TestCafe Sep 14, 2023
@tianfeng92
Copy link
Contributor Author

Hold this PR. This feature should be released after framework September release.

@tianfeng92 tianfeng92 changed the title HOLD: feat: Support setting reporters for TestCafe feat: Support setting reporters for TestCafe Jan 3, 2024
@tianfeng92 tianfeng92 force-pushed the devx-2465-testcafe-reporter branch from a515f9d to 1516a73 Compare January 3, 2024 16:20
@tianfeng92 tianfeng92 marked this pull request as ready for review January 3, 2024 17:26
@tianfeng92 tianfeng92 requested a review from a team as a code owner January 3, 2024 17:26
api/v1alpha/framework/testcafe.schema.json Outdated Show resolved Hide resolved
internal/cmd/run/testcafe.go Outdated Show resolved Hide resolved
mhan83
mhan83 previously approved these changes Jan 3, 2024
@tianfeng92 tianfeng92 merged commit ce8f67f into main Jan 3, 2024
18 checks passed
@tianfeng92 tianfeng92 deleted the devx-2465-testcafe-reporter branch January 3, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants