Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support custom regions #854

Merged
merged 10 commits into from
Nov 27, 2023
Merged

feat: Support custom regions #854

merged 10 commits into from
Nov 27, 2023

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Nov 15, 2023

Proposed changes

Allow user defined regions by reading a file at ~/.sauce/regions.yml that defines a list of regions, e.g.:

- name: local
  apiBaseURL: "https://local-api"
  appBaseURL: "https://local-app"
  webdriverBaseURL: "https://local-wd"

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@mhan83 mhan83 added the ignore-for-release Pull requests that aren't release relevant label Nov 15, 2023
@mhan83 mhan83 marked this pull request as ready for review November 16, 2023 16:37
@mhan83 mhan83 requested a review from a team as a code owner November 16, 2023 16:37
internal/region/region.go Outdated Show resolved Hide resolved
internal/region/region.go Outdated Show resolved Hide resolved
internal/region/region.go Outdated Show resolved Hide resolved
internal/region/region.go Outdated Show resolved Hide resolved
@mhan83 mhan83 requested a review from alexplischke November 27, 2023 17:13
@mhan83 mhan83 merged commit 0a19867 into main Nov 27, 2023
18 checks passed
@mhan83 mhan83 deleted the devx-2637 branch November 27, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Pull requests that aren't release relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants