Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support regional credentials #858

Merged
merged 5 commits into from
Nov 28, 2023
Merged

feat: Support regional credentials #858

merged 5 commits into from
Nov 28, 2023

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Nov 24, 2023

Proposed changes

Allow defining credentials for both built-in and custom defined regions.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

  • All sauce regions will still default to env vars and ~/.sauce/credentials.yml by default but can be overridden in regions.yml like so:
- name: us-west-1
  credentials:
    username: customUser
    accessKey: customKey
  • Since even sauce regions can be overridden, there is no longer global default credentials. So clients now access credentials from the configured region instead of the credentials package.

DEVX-2637

Base automatically changed from devx-2637 to main November 27, 2023 21:16
@mhan83 mhan83 changed the title wip: regional creds feat: Support regional credentials Nov 27, 2023
@mhan83 mhan83 force-pushed the devx-2637-with-creds branch from 1be17d4 to 33ad7c0 Compare November 27, 2023 21:18
@mhan83 mhan83 marked this pull request as ready for review November 27, 2023 21:28
@mhan83 mhan83 requested a review from a team as a code owner November 27, 2023 21:28
@mhan83 mhan83 added the ignore-for-release Pull requests that aren't release relevant label Nov 27, 2023
@mhan83 mhan83 merged commit e84ec40 into main Nov 28, 2023
18 checks passed
@mhan83 mhan83 deleted the devx-2637-with-creds branch November 28, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Pull requests that aren't release relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants