refactor: improve imagerunner cloudevent handling #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexplischke
added
the
ignore-for-release
tianfeng92
reviewed
Jan 26, 2024
Co-authored-by: Tian Feng <[email protected]>
Co-authored-by: Tian Feng <[email protected]>
Co-authored-by: Tian Feng <[email protected]>
Co-authored-by: Tian Feng <[email protected]>
tianfeng92
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Try to improve code quality and clarity of the cloudevent handling logic (e.g. live-logs).
No business logic changes per se, but some methods were more drastically altered than others (some inversion of booleans, consolidation or breaking apart methods) which results in internal logical changes of the program.
Out of Scope:
imagerunner/async.gocontains code to handle cloudevents and websockets. As this is code that's more related to HTTP than ImageRunner itself, I'd love to move this to thehttppackage, but not in this PR.PS: I recommend going through the individual commits, so as to better understand the changes (I know, it's plenty!).