Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch to using fmt.Println #881

Merged
merged 3 commits into from
Jan 29, 2024
Merged

fix: Switch to using fmt.Println #881

merged 3 commits into from
Jan 29, 2024

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Jan 29, 2024

Proposed changes

In several places, our code currently utilizes println() for outputting information.
However, println() is primarily meant for bootstrapping and debugging purposes, and it directs output to stderr. For standard output, we should switch to using fmt.Println().

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@tianfeng92 tianfeng92 added the ignore-for-release Pull requests that aren't release relevant label Jan 29, 2024
@tianfeng92 tianfeng92 marked this pull request as ready for review January 29, 2024 21:02
@tianfeng92 tianfeng92 requested a review from a team as a code owner January 29, 2024 21:02
@tianfeng92 tianfeng92 merged commit 344f3a0 into main Jan 29, 2024
18 checks passed
@tianfeng92 tianfeng92 deleted the fix-println-in-cli branch January 29, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Pull requests that aren't release relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants