fix: incorrect espresso and xcuitest flags #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Shouldn't
saucectl/internal/config/config.go
Line 218 in fca048e
saucectl/internal/job/options.go
Line 122 in fca048e
GroupDirectory then as well?
Yes. That name do convert to the correct value during serialization but for consistency, I also renamed the golang name. 👍 |
tianfeng92
reviewed
Jan 15, 2025
tianfeng92
reviewed
Jan 15, 2025
alexplischke
changed the title
tianfeng92
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up PR to address missing review items in the original instrumentation update