Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always set an appName if the app list is populated #123

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Nov 1, 2024

Description

The VSCodeDropdown component can't show an empty selection if it has any options. Since the app list is populated after a fetch, the dropdown will default to selecting the first element even if appName in state is an empty string.

DEVX-3070

The VSCodeDropdown component can't show an empty selection if it has any
options. Since the app list is populated after a fetch, the dropdown
will default to selecting the first element even if appName in state is
an empty string.

[DEVX-3070]
@mhan83 mhan83 requested a review from a team as a code owner November 1, 2024 17:46
Copy link
Contributor

@tianfeng92 tianfeng92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mhan83 mhan83 merged commit 79570fa into main Nov 1, 2024
1 check passed
@mhan83 mhan83 deleted the devx-3070 branch November 1, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants