Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1380 pytorch 260 #1382

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

1380 pytorch 260 #1382

wants to merge 2 commits into from

Conversation

manuelgloeckler
Copy link
Contributor

There are some unusual issues with Pyright in the new version of PyTorch, 2.6.0. Specifically:

  • Any buffers or parameters no longer support mathematical operations according to Pyright which is wrong.
  • There are multiple Pyright errors related to modules and tensors that shouldn't be happening.

I have used "type: ignore" to bypass these issues. Probably we should add comments at each ignore that it is due to PyTorch 2.6.0. (Assuming Pyright will fix this at some point)

@manuelgloeckler manuelgloeckler linked an issue Jan 30, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (6d527f7) to head (de8f9c8).

Files with missing lines Patch % Lines
sbi/inference/trainers/npe/npe_a.py 28.57% 5 Missing ⚠️
sbi/inference/trainers/npe/npe_c.py 0.00% 3 Missing ⚠️
sbi/inference/abc/smcabc.py 0.00% 2 Missing ⚠️
sbi/neural_nets/estimators/nflows_flow.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1382       +/-   ##
===========================================
- Coverage   89.31%   78.45%   -10.87%     
===========================================
  Files         119      119               
  Lines        8779     8786        +7     
===========================================
- Hits         7841     6893      -948     
- Misses        938     1893      +955     
Flag Coverage Δ
unittests 78.45% <42.10%> (-10.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...i/neural_nets/estimators/flowmatching_estimator.py 93.10% <100.00%> (ø)
sbi/neural_nets/estimators/score_estimator.py 92.89% <100.00%> (ø)
sbi/neural_nets/net_builders/score_nets.py 95.23% <100.00%> (+0.04%) ⬆️
sbi/neural_nets/estimators/nflows_flow.py 63.46% <0.00%> (ø)
sbi/inference/abc/smcabc.py 12.34% <0.00%> (-70.07%) ⬇️
sbi/inference/trainers/npe/npe_c.py 73.15% <0.00%> (-21.48%) ⬇️
sbi/inference/trainers/npe/npe_a.py 63.91% <28.57%> (-27.40%) ⬇️

... and 31 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyTorch 2.6.0
1 participant