HTML-36 Don't concatenate blank on nil attribute value

sbsoftware · Jun 20, 2024 · 62d90ee · 62d90ee
1 parent 7bbe065
commit 62d90ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/spec/instance_template/attributes_spec.cr b/spec/instance_template/attributes_spec.cr
@@ -8,7 +8,7 @@ module ToHtml::InstanceTemplate::AttributesSpec
     ToHtml.instance_template do
       div MyCssClass, MyOtherCssClass, {"class", "so-unique"}, more_css_classes do
         span(SPECIAL_CSS_CLASSES) { "Blah" }
-        img SPECIAL_CSS_CLASSES, more_css_classes
+        img SPECIAL_CSS_CLASSES, more_css_classes, {"class", nil}
         div MyStimulusController do
           p({"class", "so-special"}) do
             "Some content"

diff --git a/src/attribute_hash.cr b/src/attribute_hash.cr
@@ -17,7 +17,7 @@ module ToHtml
 
     def []=(key, value)
       if attributes.has_key?(key)
-        attributes[key] += " #{value}"
+        attributes[key] += " #{value}" if value
       else
         attributes[key] = value.to_s
       end