-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve text part ingestion, tokenizers and text annotations #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to work around some of the "bulkification" present in CTSImporter. Bulkification is really important for Brill (where there are textgroups with ~2.4k to 104k works. I hope to circle back and test this branch out with Brill's content to see if there are more gains to be had, but this _should_ help within Beyond Translation, which was the original goal.
YAGNI so far
Merges CSV values with the text_part_id to fit into the parallel tokenizer workflow
jacobwegner
added a commit
to scaife-viewer/beyond-translation-site
that referenced
this pull request
Nov 7, 2023
- Follow ups to ROI / Scholia, v2 #77 (scaife-viewer/frontend#78) - Improve text part ingestion, tokenizers and text annotations #68 (scaife-viewer/backend#68)
Something in implicit setup allowed SyntaxTreeNode to be registered instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs scaife-viewer/beyond-translation-site#163