Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen skolem types when adding parent refinements #22488

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

KacperFKorban
Copy link
Member

closes #22456

@KacperFKorban KacperFKorban marked this pull request as ready for review January 31, 2025 21:09
@KacperFKorban KacperFKorban requested a review from mbovel January 31, 2025 21:09
@mbovel mbovel removed their request for review February 5, 2025 10:59
@mbovel mbovel removed their assignment Feb 5, 2025
@KacperFKorban KacperFKorban force-pushed the fix-i22456 branch 2 times, most recently from 8d30ff8 to 2b99c20 Compare February 5, 2025 11:07
Copy link
Member

@mbovel mbovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

In the future, maybe we could define a "widenAllSkolems" function to be used elsewhere.

@KacperFKorban KacperFKorban merged commit ddb4bd1 into scala:main Feb 6, 2025
29 checks passed
@KacperFKorban KacperFKorban deleted the fix-i22456 branch February 6, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental compiler error with tracked val in parent trait and skolem type
2 participants