Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better recovery from parsing errors in local statements #22657

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Feb 24, 2025

TODO:

  • List all the modifiers (per category) that should be allowed / not allowed for local definitions
  • Add a check in Checking.scala for all the modifiers that are not allowed to be in local definitions
  • Update the checkfiles and check that they are behaving correctly wrt the proposed change

FYI: We will pick up the rest of the work in the next spree ;-)

Closes #22631

@hamzaremmal hamzaremmal self-assigned this Feb 24, 2025
@tgodzik
Copy link
Contributor

tgodzik commented Feb 25, 2025

That's super useful from the presentation compiler view 😍

@hamzaremmal hamzaremmal changed the title Better recover from parsing errors in local statements Better recovery from parsing errors in local statements Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No graceful recovery from misplaced private modifier in local scope
2 participants