Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nowarn public implicit val class params #22664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Nowarn public implicit val class params #22664

wants to merge 1 commit into from
+37 −2

Conversation

som-snytt
Copy link
Contributor

Similar to explicit param.

Fixes #22662

@som-snytt
Nowarn non-private implicit val class params
0a80777 
Dowarn protected param accessor of given class,
which is further constrained to be protected only
for simply named params that the user might reference.
@som-snytt som-snytt force-pushed the issue/22662-implicit-val branch from 02cd651 to 0a80777 Compare February 26, 2025 18:07
@som-snytt
Copy link
Contributor Author

Explanation of protected member of given class is #8397

The warning considers any such member. But adding Protected is restricted to members the user might name. That may be wrong if a macro def f = summonInline[G].T constructs a usage of the derived name in a leaky position.

@som-snytt som-snytt marked this pull request as ready for review February 26, 2025 21:40
@Gedochao Gedochao requested a review from sjrd February 27, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd Awaiting requested review from sjrd

At least 1 approving review is required to merge this pull request.

Assignees

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't warn using val
2 participants
@som-snytt @sjrd