bugfix: Make sure to choose the best import option #7285
+112
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
fix-import-all
branch
2 times, most recently
from
4e3b610 to
2699924
Compare
When importing symbols in a range it might turn out we are able to get a better suggestions in a certain spot in the file. For example if we know that one object has a specific method while the other doesn't. This means that this import is better for the entire file since it's more concrete. Previously, we would still show all options, but now search for the shortest action choice for each missing symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing symbols in a range it might turn out we are able to get a better suggestions in a certain spot in the file.
For example if we know that one object has a specific method while the other doesn't.
This means that this import is better for the entire file since it's more concrete.
Previously, we would still show all options, but now search for the shortest action choice for each missing symbol.