Skip to content

Commit

Permalink
Merge pull request #186 from scality/bugfix/ZENKO-710-https-proxy
Browse files Browse the repository at this point in the history
bf: allow optional proxy certs
  • Loading branch information
giacomoguiulfo authored Jul 12, 2018
2 parents 30b31d3 + 96e29a7 commit 5a7e9a7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/cloudserver-front/templates/certificate.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.proxy.https -}}
{{- if .Values.proxy.caCert -}}
apiVersion: v1
kind: Secret
metadata:
Expand Down
6 changes: 4 additions & 2 deletions charts/cloudserver-front/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ spec:
value: "{{ .Values.proxy.https }}"
- name: HTTPS_PROXY
value: "{{ .Values.proxy.https }}"
{{- end }}
{{- if .Values.proxy.caCert }}
- name: NODE_EXTRA_CA_CERTS
value: "/ssl/ca.crt"
{{- end }}
Expand Down Expand Up @@ -109,7 +111,7 @@ spec:
path: /_/healthcheck
port: http
volumeMounts:
{{- if .Values.proxy.https }}
{{- if .Values.proxy.caCert }}
- name: proxy-cert
mountPath: "/ssl"
readOnly: true
Expand All @@ -129,7 +131,7 @@ spec:
{{ toYaml . | indent 8 }}
{{- end }}
volumes:
{{- if .Values.proxy.https }}
{{- if .Values.proxy.caCert }}
- name: proxy-cert
secret:
secretName: {{ template "cloudserver-front.fullname" . }}-proxy
Expand Down
6 changes: 4 additions & 2 deletions charts/cloudserver-front/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,12 @@ proxy:
# If you want to use an HTTP proxy, add the respective endpoints after
# 'http:' and/or 'https:'. If the HTTP proxy endpoint is set but the HTTPS
# one isn't, the HTTP proxy will be used for HTTPS traffic as well.
# Additionally, if the HTTPS proxy is set, you will need to provide an
# ssl certificate in a file named 'ca.crt' at the root path of this chart.
# Additionally you can pass a CA certifcate that will be added to the trusted
# certs. If the proxy URL is configured and caCert is true, helm
# will look for a file named 'ca.crt' at the root path of this chart.
http: ""
https: ""
caCert: false

service:
type: ClusterIP
Expand Down

0 comments on commit 5a7e9a7

Please sign in to comment.